FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ProcessPoolExecutor deadlock when a child process crashes while data is being sent in call queue · Issue #94777 · python/cpython · GitHub

Repository navigation

ProcessPoolExecutor deadlock when a child process crashes while data is being sent in call queue #94777

Closed

Description

Bug report

When using a ProcessPoolExecutor with forked child processes, if one of the child processes suddenly dies (segmentation fault, not a Python exception) and if simultaneously data is being sent into the call queue, then the parent process hangs forever.

Reproduction

import ctypes
from concurrent.futures import ProcessPoolExecutor


def segfault():
    ctypes.string_at(0)


def func(i, data):
    print(f"Start {i}.")
    if i == 1:
        segfault()
    print(f"Done {i}.")
    return i


data = list(range(100_000_000))
count = 10
with ProcessPoolExecutor(2) as pool:
    list(pool.map(func, range(count), [data] * count))
print(f"OK")

In Python 3.8.10 it raises a BrokenProcessPool exception whereas in 3.9.13 and 3.10.5 it hangs.

Analysis

When a crash happens in a child process, all workers are terminated and they stop reading in communication pipes. However if data is being send in the call queue, the call queue thread which writes data from buffer to pipe (multiprocessing.queues.Queue._feed) can get stuck in send_bytes(obj) when the unix pipe it's writing to is full. _ExecutorManagerThread is blocked in self.join_executor_internals() on line

self.call_queue.join_thread()
(called from self.terminate_broken()). The main thread itself is blocked on
self._executor_manager_thread.join()
coming from the __exit__ method of the Executor.

Proposed solution

Drain call queue buffer either in terminate_broken method before calling join_executor_internals or in queue close method.
I will create a pull request with a possible implementation.

Your environment

  • CPython versions tested on: reproduced in 3.10.5 and 3.9.13 (works well in 3.8.10: BrokenProcessPool exception)
  • Operating system and architecture: Linux, x86_64

Linked PRs

Activity

  1. lpaulot commented on Jul 12, 2022

    ContributorAuthor

    It was probably introduced by #31913 .
    Call queue reader used to be closed in self.call_queue.close() in join_executor_internals() before calling self.call_queue.join_thread(). In pull request #94784 I propose to close this reader end only in case of an already broken pool.

  2. changed the title [-]ProcessPoolExecutor hangs when a child process crashes while data is being sent in call queue[/-] [+]ProcessPoolExecutor deadlock when a child process crashes while data is being sent in call queue[/+] on Jul 13, 2022
  3. added a commit that references this issue on Jul 10, 2023
  4. added 2 commits that reference this issue on Jul 10, 2023
  5. added a commit that references this issue on Jul 10, 2023
  6. added a commit that references this issue on Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL