FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-100005: Skip test_script_as_dev_fd() on FreeBSD by vstinner · Pull Request #100006 · python/cpython · GitHub

Repository navigation

gh-100005: Skip test_script_as_dev_fd() on FreeBSD - #100006

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_script_as_dev_fd
Dec 5, 2022
Merged

vstinner merged 1 commit into
python:mainfrom
vstinner:test_script_as_dev_fd

Conversation

vstinner commented Dec 5, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if fdescfs is not mounted (at /dev/fd).

On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if
fdescfs is not mounted (at /dev/fd).

vstinner commented Dec 5, 2022

Copy link
Copy Markdown
Member Author

With this PR, the test is now skipped on FreeBSD:

$ ./python -m test test_cmd_line_script -v -m test_script_as_dev_fd
(...)
test_script_as_dev_fd (test.test_cmd_line_script.CmdLineTest.test_script_as_dev_fd) ... skipped 'Requires fdescfs mounted on /dev/fd on FreeBSD'

If I mount manually /dev/fd, it works as expected:

$ sudo mount -t fdescfs none /dev/fd 

$ ./python -m test test_cmd_line_script -v -m test_script_as_dev_fd
(...)
test_script_as_dev_fd (test.test_cmd_line_script.CmdLineTest.test_script_as_dev_fd) ... 

/usr/home/vstinner/python/main/Lib/subprocess.py:849: RuntimeWarning: pass_fds overriding close_fds.
  warnings.warn("pass_fds overriding close_fds.", RuntimeWarning)

ok
(...)

cc @ronaldoussoren


By the way, the test emits a warning because of this Lib/subprocess.py code:

            if pass_fds and not close_fds:
                warnings.warn("pass_fds overriding close_fds.", RuntimeWarning)
                close_fds = True

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 038b151963d9d4a5f4c852544fb5b0402ffcb218 3.10

Copy link
Copy Markdown

GH-100007 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
…0006)

On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if
fdescfs is not mounted (at /dev/fd).
(cherry picked from commit 038b151)

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner commented Dec 5, 2022

Copy link
Copy Markdown
Member Author

Ah, test_script_as_dev_fd() was not backported to Python 3.10.

miss-islington added a commit that referenced this pull request Dec 5, 2022
On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if
fdescfs is not mounted (at /dev/fd).
(cherry picked from commit 038b151)

Co-authored-by: Victor Stinner <vstinner@python.org>

encukou commented Oct 8, 2024

Copy link
Copy Markdown
Member

It was, in #99817.
This fails on the stable buildbot, so it should be backported to 3.10 & 3.9.

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 038b151963d9d4a5f4c852544fb5b0402ffcb218 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2024
…0006)

On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if
fdescfs is not mounted (at /dev/fd).
(cherry picked from commit 038b151)

Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

GH-125109 is a backport of this pull request to the 3.10 branch.

pablogsal pushed a commit that referenced this pull request Oct 22, 2024
…#125109)

gh-100005: Skip test_script_as_dev_fd() on FreeBSD (GH-100006)

On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if
fdescfs is not mounted (at /dev/fd).
(cherry picked from commit 038b151)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL