| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Not sure if we want buildbots on this (normally I would run them, but I also don't want to further delay the releases with a bunch of extra CI checks). I'm confident in the fix, though. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 6210626 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
Thanks a lot for fixing this ❤️ I am executing the buildbots at least to see the quick ones to double check there is nothing unexpected. I will manually test Refleaks after before the release. |
Sorry, something went wrong.
|
Hm, looks like we need to skip the new test on webassembly builds. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit af155c7 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
Looks good. I think the buildbot failures are unrelated. |
Sorry, something went wrong.
|
Thanks @brandtbucher for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
|
Sorry, @brandtbucher and @pablogsal, I could not cleanly backport this to 3.11 due to a conflict. |
Sorry, something went wrong.
|
Thanks for fixing this @brandtbucher! ❤️
Please, ping me as soon as you have the manual backport ready |
Sorry, something went wrong.
I opened it yesterday: #100047 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Thanks for your patience with this.
I decided to switch strategies mid-fix after a discussion with @markshannon this morning: instead of hacking the frame to look "incomplete" just before teardown, I think unlinking the frame before clearing it (instead of after) is a better approach that is easier to reason about and keeps extra code out of the hot path when popping frames.
This is going to need a manual backport to 3.11. I'll start on it now to hopefully unblock releases.
CC: @pablogsal