gh-99941: asyncio.Protocol.data_received now received immutable bytes - #100053
Merged
gvanrossum merged 4 commits intoDec 10, 2022
Merged
gh-99941: asyncio.Protocol.data_received now received immutable bytes#100053gvanrossum merged 4 commits into
gvanrossum merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
DarioDaF
requested review from
1st1,
asvetlov,
gvanrossum and
kumaraditya303
as code owners
December 6, 2022 10:22
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@gvanrossum Is this what you intended? I thought that we were going for a documentation update and some unittests though I might be misunderstanding. If this is to be accepted then we need more benchmarks with larger payloads to verify. |
Sorry, something went wrong.
gvanrossum
approved these changes
Dec 10, 2022
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Just some nits for the news entry. I'll apply that and then merge.
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Windows/2022-12-06-11-16-46.gh-issue-99941.GmUQ6o.rst
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made asyncio.Protocol.data_received receive immutable object
bytes instead of bytearrays (like defined in the docs) with regression tests added
and opted to use memoryview to take the slices for performance on big buffers.
Performance test from #21442 done on my machine with 10
repetitions on release build with timings 0.043 (delta: 0.019) before patch
and 0.041 (delta: 0.010) after so no noticable change in performance.