gh-81057: Move OS-Related Globals to _PyRuntimeState - #100082
Merged
ericsnowcurrently merged 6 commits intoDec 8, 2022
Merged
Conversation
Copy link
Copy Markdown
✅ Deploy Preview for python-cpython-preview canceled.
|
Sorry, something went wrong.
ericsnowcurrently
force-pushed
the
consolidate-os-globals
branch
from
3f8e780 to
62179ba
Compare
December 8, 2022 17:12
ericsnowcurrently
force-pushed
the
consolidate-os-globals
branch
from
adc9260 to
b8befdc
Compare
December 8, 2022 22:04
Copy link
Copy Markdown
Member
|
This change introduced a reference leak. Example with test_posixpath: $ ./python -m test test_posixpath -R 3:3 -m test_ismount_directory_not_readable (...) test_posixpath leaked [9, 9, 9] references, sum=27 (...) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
On PPC64LE Fedora Stable Refleaks 3.x, test_os and test_posixpath started to leak memory: https://buildbot.python.org/all/#builders/280/builds/548 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'll get that fixed. |
Sorry, something went wrong.
ericsnowcurrently
added a commit
that referenced
this pull request
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.