FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-81057: Move Threading-Related Globals to _PyRuntimeState by ericsnowcurrently · Pull Request #100084 · python/cpython · GitHub

/ cpython Public

gh-81057: Move Threading-Related Globals to _PyRuntimeState - #100084

Merged
ericsnowcurrently merged 8 commits into
python:mainfrom
ericsnowcurrently:consolidate-threading-globals
Dec 9, 2022
ConversationCommits (8)ChecksFiles changed
Merged

gh-81057: Move Threading-Related Globals to _PyRuntimeState#100084
ericsnowcurrently merged 8 commits into
python:mainfrom
ericsnowcurrently:consolidate-threading-globals

Conversation

ericsnowcurrently commented Dec 7, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

ericsnowcurrently requested a review from a team as a code owner December 7, 2022 17:17

netlify Bot commented Dec 7, 2022 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 3c22543
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6392802b0234d300086d75f9
😎 Deploy Preview https://deploy-preview-100084--python-cpython-preview.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bedevere-bot mentioned this pull request Dec 7, 2022
Closed
ericsnowcurrently removed the request for review from a team December 7, 2022 17:17
ericsnowcurrently force-pushed the consolidate-threading-globals branch from f2399f9 to f05396b Compare December 8, 2022 01:34

kumaraditya303 commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

How about changing the thread initializer PyThread_init_thread to be always called on startup? It will eliminate these globals altogether be threadsafe so will help in per interpreter GIL too.

ericsnowcurrently commented Dec 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

It's called when the GIL is created, which is already a part of initializing the main interpreter. Perhaps I misunderstood what you meant?

ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2022

bedevere-bot commented Dec 8, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit f05396b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2022
ericsnowcurrently force-pushed the consolidate-threading-globals branch from f05396b to 3c22543 Compare December 9, 2022 00:24
ericsnowcurrently merged commit 1160001 into python:main Dec 9, 2022
ericsnowcurrently deleted the consolidate-threading-globals branch December 9, 2022 00:51

vstinner commented Dec 9, 2022

Copy link
Copy Markdown
Member

This change broke the wasm32-wasi 3.x buildbot: https://buildbot.python.org/all/#/builders/1046/builds/1051

ericsnowcurrently commented Dec 9, 2022

Copy link
Copy Markdown
Member Author

I'll look into it.

ericsnowcurrently mentioned this pull request Dec 9, 2022
Merged
ericsnowcurrently added a commit that referenced this pull request Dec 9, 2022
gh-81057: Fix the wasm32-wasi Buildbot (gh-100139)
8d0bd93 
The build was broken by gh-100084.

#81057
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL