FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] GH-98363: Update batched() recipe in docs to match 3.12 by rhettinger · Pull Request #100323 · python/cpython · GitHub

/ cpython Public

[3.11] GH-98363: Update batched() recipe in docs to match 3.12 - #100323

Merged
rhettinger merged 2 commits into
python:3.11from
rhettinger:batched_recipe_tuple
Dec 18, 2022
ConversationCommits (2)ChecksFiles changed
Merged

[3.11] GH-98363: Update batched() recipe in docs to match 3.12#100323
rhettinger merged 2 commits into
python:3.11from
rhettinger:batched_recipe_tuple

Conversation

rhettinger commented Dec 17, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

rhettinger added docs Documentation in the Doc dir skip news labels Dec 17, 2022
bedevere-bot mentioned this pull request Dec 17, 2022
Closed
hauntsaninja reviewed Dec 17, 2022
View reviewed changes
Comment thread Doc/library/itertools.rst Outdated
CAM-Gerlach approved these changes Dec 18, 2022
View reviewed changes

CAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM from a docs perspective, FWIW. Should this be backported to 3.10 as well?

CAM-Gerlach mentioned this pull request Dec 18, 2022
Closed

CAM-Gerlach commented Dec 18, 2022

Copy link
Copy Markdown
Member

Also, I noticed that though this PR was made from your fork per the usual flow. there is an apparent duplicate https://github.com/python/cpython/tree/batched_recipe_tuple branch on the upstream cpython repo. Does that need to be there, or can it be removed? It's the final blocker to implementing the final step of python/core-workflow#460 on cpython. Thanks!

rhettinger merged commit 0918667 into python:3.11 Dec 18, 2022
rhettinger deleted the batched_recipe_tuple branch December 18, 2022 01:10

rhettinger commented Dec 18, 2022

Copy link
Copy Markdown
Contributor Author

@CAM-Gerlach Yes, go ahead and remove the other branch.

CAM-Gerlach commented Dec 18, 2022

Copy link
Copy Markdown
Member

Thanks, removed! 👍

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja left review comments
CAM-Gerlach CAM-Gerlach approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL