gh-100321: Remove redundant variable newfree in function analyze_block - #100327
Closed
zikcheng wants to merge 1 commit into
Closed
gh-100321: Remove redundant variable newfree in function analyze_block#100327zikcheng wants to merge 1 commit into
zikcheng wants to merge 1 commit into
Conversation
JosephSBoyle
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Hi.
What do the "newfree" and "allfree" vars represent?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hi @JosephSBoyle , in my understanding, allfree represents all free variables in children blocks and newfree is just a copy of allfree. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@zikcheng Thanks for clarifying for me:) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
In #101441, the allfree variable was removed instead. Sorry that we missed this PR! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.