FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-99908 Update class documentation to use a modernized example by JosephSBoyle · Pull Request #100433 · python/cpython · GitHub

/ cpython Public

gh-99908 Update class documentation to use a modernized example - #100433

Closed
JosephSBoyle wants to merge 3 commits into
python:mainfrom
JosephSBoyle:fix-issue-99908
Closed

gh-99908 Update class documentation to use a modernized example#100433
JosephSBoyle wants to merge 3 commits into
python:mainfrom
JosephSBoyle:fix-issue-99908

Conversation

JosephSBoyle commented Dec 22, 2022
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Small update to the docs to improve on an outmoded example from 15 years ago.
The aim of this change is to give readers of the docs a more idiomatic example.

ghost commented Dec 22, 2022
edited by ghost
Loading

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:

Copy link
Copy Markdown
Member

Hi, @JosephSBoyle! Could you please sign a CLA? We cannot accept your PR without it :(

JosephSBoyle commented Dec 22, 2022
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @sobolevn. I have accepted the CLA. Can you re-run the check please? (I had to change my email address in the commit to my GH one).

Comment thread Doc/tutorial/classes.rst
Comment thread Doc/tutorial/classes.rst Outdated

sobolevn commented Dec 23, 2022
edited
Loading

Copy link
Copy Markdown
Member

@JosephSBoyle are you sure that your git email is the same as your CLA email: joe.boyle@blackcowtech.uk?
Looks like CLA status is not updated :(
Usually it happens in <1 hour.

Copy link
Copy Markdown
Contributor Author

Hi @sobolevn, thanks for the reminder- I had to rebase and edit my email in the commit log to have the same email as my CLA. Should be fine now:)

Copy link
Copy Markdown
Member

Hi @sobolevn, thanks for the reminder- I had to rebase and edit my email in the commit log to have the same email as my CLA. Should be fine now:)

Looks like the CLA bot is still being grumpy — it might be easier to just close the PR and recreate it :)

JosephSBoyle marked this pull request as draft December 24, 2022 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL