gh-100488: Add is_integer method to fractions.Fraction - #100489
Merged
hauntsaninja merged 3 commits intoJan 1, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Author
|
The documentation guarantees that denominator is in lowest term. It doesn't make any explicit guarantee about being positive, but as_integer_ratio does and just returns the denominator. But do let me know if I should change to abs(self._denominator) == 1 or self._numerator % self._denominator == 0! |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Dec 24, 2022
JelleZijlstra
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
(But let's wait for Mark to also give feedback.)
Sorry, something went wrong.
mdickinson
approved these changes
Dec 29, 2022
mdickinson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM; one reST markup nitpick.
Sorry, something went wrong.
Comment thread
Doc/library/fractions.rst
Outdated
Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.