FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-100126: Skip incomplete frames in more places by brandtbucher · Pull Request #100613 · python/cpython · GitHub

/ cpython Public

GH-100126: Skip incomplete frames in more places - #100613

Merged
brandtbucher merged 7 commits into
python:mainfrom
brandtbucher:incomplete-frames-everywhere
Jan 9, 2023
ConversationCommits (7)ChecksFiles changed
Merged

GH-100126: Skip incomplete frames in more places#100613
brandtbucher merged 7 commits into
python:mainfrom
brandtbucher:incomplete-frames-everywhere

Conversation

brandtbucher commented Dec 30, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Also, add two new internal APIs (_PyFrame_GetComplete and _PyThreadState_GetFrame) to make this common move a bit cleaner.

brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-crash A hard crash of the interpreter, possibly with a core dump labels Dec 30, 2022
brandtbucher self-assigned this Dec 30, 2022
bedevere-bot mentioned this pull request Dec 30, 2022
Closed
brandtbucher added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 30, 2022

bedevere-bot commented Dec 30, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 53d066e 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 30, 2022

brandtbucher commented Dec 30, 2022

Copy link
Copy Markdown
Member Author

The one failing buildbot (ARM64 Windows) has been failing on other PRs too.

markshannon reviewed Jan 5, 2023
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One quibble about naming.

Looks good. Hopefully this is the last of the frame stack traversal issues.

Comment thread Include/internal/pycore_frame.h Outdated
}

static inline _PyInterpreterFrame *
_PyFrame_GetComplete(_PyInterpreterFrame *frame)

markshannon Jan 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This name gives no sense of traversing the stack until a complete frame is found.
Maybe _PyFrame_GetFirstComplete()?

brandtbucher merged commit 61762b9 into python:main Jan 9, 2023
A5rocks mentioned this pull request Jan 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon left review comments

Assignees

brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL