FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-100776: Fix misleading default value in help(input) by hauntsaninja · Pull Request #100788 · python/cpython · GitHub

/ cpython Public

gh-100776: Fix misleading default value in help(input) - #100788

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
hauntsaninja:gh-100776
Jan 8, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-100776: Fix misleading default value in help(input)#100788
kumaraditya303 merged 2 commits into
python:mainfrom
hauntsaninja:gh-100776

Conversation

hauntsaninja commented Jan 6, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Jan 6, 2023
Closed
hauntsaninja changed the title gh-100776: Make input's __text_signature__ less misleading gh-100776: Make help(input) less misleading Jan 6, 2023
hauntsaninja changed the title gh-100776: Make help(input) less misleading gh-100776: Fix misleading default value in help(input) Jan 6, 2023
sobolevn approved these changes Jan 6, 2023
View reviewed changes

sobolevn left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! input() does the same thing as input("") (the new default).

hauntsaninja commented Jan 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Note that this doesn't actually change the behaviour of input, just the docstring. Either way, the actual default is NULL :-)

kumaraditya303 merged commit a214188 into python:main Jan 8, 2023
hauntsaninja deleted the gh-100776 branch January 8, 2023 08:29
hauntsaninja added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 8, 2023

miss-islington commented Jan 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington commented Jan 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Jan 8, 2023

Copy link
Copy Markdown
Contributor

Sorry, @hauntsaninja and @kumaraditya303, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a2141882f259e21bb09fa0b7cba8142147b9e3d7 3.10

miss-islington commented Jan 8, 2023

Copy link
Copy Markdown
Contributor

Sorry @hauntsaninja and @kumaraditya303, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a2141882f259e21bb09fa0b7cba8142147b9e3d7 3.11

bedevere-bot commented Jan 8, 2023

Copy link
Copy Markdown

GH-100841 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 8, 2023

hauntsaninja commented Jan 8, 2023

Copy link
Copy Markdown
Contributor Author

I can do the backports

hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Jan 8, 2023
[3.11] pythongh-100776: Fix misleading default value in help(input) (p…
73e247f 
…ythonGH-100788).

(cherry picked from commit a214188)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

bedevere-bot commented Jan 8, 2023

Copy link
Copy Markdown

GH-100842 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 8, 2023
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Jan 8, 2023
[3.10] pythongh-100776: Fix misleading default value in help(input) (p…
685bc1c 
…ythonGH-100788).

(cherry picked from commit a214188)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja added a commit that referenced this pull request Jan 8, 2023
[3.11] gh-100776: Fix misleading default value in help(input) (GH-100788
be7c197 
) (#100841)

(cherry picked from commit a214188)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja added a commit that referenced this pull request Jan 8, 2023
[3.10] gh-100776: Fix misleading default value in help(input) (GH-100788
a8702bb 
) (#100842)

(cherry picked from commit a214188)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn approved these changes
kumaraditya303 kumaraditya303 approved these changes

Assignees

kumaraditya303

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL