gh-100783: fix os.path.join documentation - #100811
Merged
hauntsaninja merged 6 commits intoJan 8, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- Use "drive", not "drive letter", because of UNC paths - Previous components are not thrown away from relative drive letters - Use "segment" instead of "component" for consistency with pathlib See issue for more details
eryksun
reviewed
Jan 6, 2023
Comment thread
Doc/library/os.path.rst
Outdated
eryksun
reviewed
Jan 6, 2023
Comment thread
Doc/library/os.path.rst
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, made the changes! |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Jan 7, 2023
JelleZijlstra
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, one nit in nearby code.
Sorry, something went wrong.
Comment thread
Doc/library/os.path.rst
Outdated
hauntsaninja
commented
Jan 7, 2023
Comment thread
Doc/library/os.path.rst
Outdated
eryksun
reviewed
Jan 8, 2023
Comment thread
Doc/library/os.path.rst
Copy link
Copy Markdown
Contributor
|
Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-100843 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-100844 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2023
- Use "drive", not "drive letter", because of UNC paths - Previous components are not thrown away from relative drive letters - Use "segment" instead of "component" for consistency with pathlib - Other miscellaneous improvements (cherry picked from commit 53455a3) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2023
- Use "drive", not "drive letter", because of UNC paths - Previous components are not thrown away from relative drive letters - Use "segment" instead of "component" for consistency with pathlib - Other miscellaneous improvements (cherry picked from commit 53455a3) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jan 8, 2023
- Use "drive", not "drive letter", because of UNC paths - Previous components are not thrown away from relative drive letters - Use "segment" instead of "component" for consistency with pathlib - Other miscellaneous improvements (cherry picked from commit 53455a3) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jan 8, 2023
- Use "drive", not "drive letter", because of UNC paths - Previous components are not thrown away from relative drive letters - Use "segment" instead of "component" for consistency with pathlib - Other miscellaneous improvements (cherry picked from commit 53455a3) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja
added a commit
to hauntsaninja/cpython
that referenced
this pull request
Jan 29, 2023
This is a follow-up to python#100811. One of the changes in that PR isn't accurate in that `os.path.join('', '')` will not end in a separator. This reverts that change to the previous wording that used "only", but explicitly calls out the case where the last part ends in a separator, which is what caused confusin in python#77607 and motivated the change in python#100811.
hauntsaninja
added a commit
that referenced
this pull request
Jan 31, 2023
This is a follow-up to #100811. One of the changes in that PR isn't accurate in that `os.path.join('', '')` will not end in a separator. This reverts that change to the previous wording that used "only", but explicitly calls out the case where the last part ends in a separator, which is what caused confusin in #77607 and motivated the change in #100811.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 31, 2023
This is a follow-up to pythonGH-100811. One of the changes in that PR isn't accurate in that `os.path.join('', '')` will not end in a separator. This reverts that change to the previous wording that used "only", but explicitly calls out the case where the last part ends in a separator, which is what caused confusin in pythonGH-77607 and motivated the change in pythonGH-100811. (cherry picked from commit 909a674) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 31, 2023
This is a follow-up to pythonGH-100811. One of the changes in that PR isn't accurate in that `os.path.join('', '')` will not end in a separator. This reverts that change to the previous wording that used "only", but explicitly calls out the case where the last part ends in a separator, which is what caused confusin in pythonGH-77607 and motivated the change in pythonGH-100811. (cherry picked from commit 909a674) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jan 31, 2023
This is a follow-up to GH-100811. One of the changes in that PR isn't accurate in that `os.path.join('', '')` will not end in a separator. This reverts that change to the previous wording that used "only", but explicitly calls out the case where the last part ends in a separator, which is what caused confusin in GH-77607 and motivated the change in GH-100811. (cherry picked from commit 909a674) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jan 31, 2023
This is a follow-up to GH-100811. One of the changes in that PR isn't accurate in that `os.path.join('', '')` will not end in a separator. This reverts that change to the previous wording that used "only", but explicitly calls out the case where the last part ends in a separator, which is what caused confusin in GH-77607 and motivated the change in GH-100811. (cherry picked from commit 909a674) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
mdboom
pushed a commit
to mdboom/cpython
that referenced
this pull request
Jan 31, 2023
This is a follow-up to python#100811. One of the changes in that PR isn't accurate in that `os.path.join('', '')` will not end in a separator. This reverts that change to the previous wording that used "only", but explicitly calls out the case where the last part ends in a separator, which is what caused confusin in python#77607 and motivated the change in python#100811.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue for more details