FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-100871: Improve `copy` module tests by sobolevn · Pull Request #100872 · python/cpython · GitHub

/ cpython Public

gh-100871: Improve copy module tests - #100872

Merged
miss-islington merged 3 commits into
python:mainfrom
sobolevn:issue-100871
Jan 11, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-100871: Improve copy module tests#100872
miss-islington merged 3 commits into
python:mainfrom
sobolevn:issue-100871

Conversation

sobolevn commented Jan 9, 2023 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

CC @AlexWaygood as the reviewer of #100818

Automerge-Triggered-By: GH:AlexWaygood

bedevere-bot mentioned this pull request Jan 9, 2023
Closed
bedevere-bot added the tests Tests in the Lib/test dir label Jan 9, 2023
AlexWaygood self-requested a review January 9, 2023 07:38

sobolevn commented Jan 9, 2023

Copy link
Copy Markdown
Member Author

The failure is clearly not related.

hauntsaninja approved these changes Jan 9, 2023
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice, thank you for this PR! (And good catch on the other PR, Alex!)

hauntsaninja reviewed Jan 9, 2023
View reviewed changes
Comment thread Lib/test/test_slice.py Outdated
hauntsaninja reviewed Jan 9, 2023
View reviewed changes
Comment thread Lib/test/test_slice.py Outdated
AlexWaygood requested changes Jan 9, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! Mostly looks good, but two nits below:

Comment thread Lib/test/test_slice.py Outdated
Comment thread Lib/test/test_slice.py Outdated

bedevere-bot commented Jan 9, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

AlexWaygood commented Jan 9, 2023

Copy link
Copy Markdown
Member

And if you don't make the requested changes, you will be poked with soft cushions!

I have them ready

Apply suggestions from code review
2fd1a25 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood approved these changes Jan 11, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

miss-islington commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

miss-islington merged commit 729ab9b into python:main Jan 11, 2023

miss-islington commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Sorry @sobolevn, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 729ab9b622957fef0e9b494af9a71ab02986c741 3.11

miss-islington self-assigned this Jan 11, 2023

miss-islington commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 729ab9b622957fef0e9b494af9a71ab02986c741 3.10

AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jan 11, 2023

miss-islington commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Sorry @sobolevn, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 729ab9b622957fef0e9b494af9a71ab02986c741 3.11

AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jan 11, 2023

miss-islington commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 729ab9b622957fef0e9b494af9a71ab02986c741 3.11

AlexWaygood commented Jan 11, 2023

Copy link
Copy Markdown
Member

@sobolevn, would you be able to handle the backports here? :)

sobolevn commented Jan 11, 2023

Copy link
Copy Markdown
Member Author

Yeap, I will add this to my backports queue :)

AlexWaygood commented Jan 11, 2023

Copy link
Copy Markdown
Member

Thank you! Ping me for review when you do, and I'll merge them :)

bedevere-bot commented Jan 12, 2023

Copy link
Copy Markdown

GH-100975 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 12, 2023
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 12, 2023
[3.10] pythongh-100871: Improve copy module tests (pythonGH-100872)
cd2738f 
CC @AlexWaygood as the reviewer of python#100818

Automerge-Triggered-By: GH:AlexWaygood.
(cherry picked from commit 729ab9b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Jan 12, 2023

Copy link
Copy Markdown

GH-100976 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 12, 2023
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 12, 2023
[3.11] pythongh-100871: Improve copy module tests (pythonGH-100872)
cfecbca 
CC @AlexWaygood as the reviewer of python#100818

Automerge-Triggered-By: GH:AlexWaygood.
(cherry picked from commit 729ab9b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
AlexWaygood pushed a commit that referenced this pull request Jan 12, 2023
[3.10] gh-100871: Improve copy module tests (GH-100872) (#100975)
ebc1fd3 
(cherry picked from commit 729ab9b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
AlexWaygood pushed a commit that referenced this pull request Jan 12, 2023
[3.11] gh-100871: Improve copy module tests (GH-100872) (#100976)
db26437 
(cherry picked from commit 729ab9b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja approved these changes
AlexWaygood AlexWaygood approved these changes

Assignees

sobolevn

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL