FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix typos in Doc folder by ss18 · Pull Request #100880 · python/cpython · GitHub

/ cpython Public

Fix typos in Doc folder - #100880

Merged
hugovk merged 3 commits into
python:mainfrom
ss18:main
Jan 10, 2023
ConversationCommits (3)ChecksFiles changed
Merged

Fix typos in Doc folder#100880
hugovk merged 3 commits into
python:mainfrom
ss18:main

Conversation

ss18 commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Addressed issue: #100879

Fixed typos:
adviced -> advised
funtion -> function
preferrably -> preferably

Found with: https://github.com/ss18/grep-typos

ss18 requested review from a team, berkerpeksag and erlend-aasland as code owners January 9, 2023 12:45

ghost commented Jan 9, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

hugovk requested changes Jan 9, 2023
View reviewed changes
Comment thread Doc/includes/email-alternative.py Outdated

bedevere-bot commented Jan 9, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

wookie184 reviewed Jan 9, 2023
View reviewed changes
Comment thread Doc/library/io.rst Outdated
wookie184 reviewed Jan 9, 2023
View reviewed changes
Comment thread Doc/license.rst Outdated

ss18 commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

@hugovk @wookie184 Thanks for feedback.

Deleted two commits:
publically -> publicly
ressemble -> resemble

CAM-Gerlach added the docs Documentation in the Doc dir label Jan 10, 2023
CAM-Gerlach requested a review from hugovk January 10, 2023 05:45
hugovk requested changes Jan 10, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@ss18 Thanks for the update, please could you also remove "seeked -> sought"?

ss18 commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

no problem, @hugovk removed "seeked -> sought".

ss18 requested review from hugovk and removed request for berkerpeksag and erlend-aasland January 10, 2023 08:53
hugovk removed the request for review from a team January 10, 2023 09:03
hugovk approved these changes Jan 10, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

hugovk merged commit 35650f2 into python:main Jan 10, 2023

miss-islington commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @ss18 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Sorry, @ss18 and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 35650f25383efce83b62d5273110ab8dcdbcc254 3.11

miss-islington commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Sorry @ss18 and @hugovk, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 35650f25383efce83b62d5273110ab8dcdbcc254 3.10

bedevere-bot commented Jan 10, 2023

Copy link
Copy Markdown

GH-100914 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 10, 2023

bedevere-bot commented Jan 10, 2023

Copy link
Copy Markdown

GH-100915 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 10, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull request Jan 10, 2023
[3.11] Fix typos in Doc folder (pythonGH-100880).
dc9ec09 
(cherry picked from commit 35650f2)

Co-authored-by: Semen Zhydenko <semen.zhydenko@gmail.com>
hugovk added a commit that referenced this pull request Jan 10, 2023
[3.11] Fix typos in Doc folder (GH-100880). (#100914)
1e74a12 
Co-authored-by: Semen Zhydenko <semen.zhydenko@gmail.com>
hugovk added a commit that referenced this pull request Jan 10, 2023
[3.10] Fix typos in Doc folder (GH-100880). (#100915)
65b01b2 
Co-authored-by: Semen Zhydenko <semen.zhydenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja left review comments
CAM-Gerlach CAM-Gerlach left review comments
hugovk hugovk approved these changes
+1 more reviewer
wookie184 wookie184 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

hugovk

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL