FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-100884: email/_header_value_parser: don't encode list separators by t-8ch · Pull Request #100885 · python/cpython · GitHub

/ cpython Public

GH-100884: email/_header_value_parser: don't encode list separators - #100885

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
t-8ch:header-folding
Feb 17, 2024
ConversationCommits (3)ChecksFiles changed
Merged

GH-100884: email/_header_value_parser: don't encode list separators#100885
serhiy-storchaka merged 3 commits into
python:mainfrom
t-8ch:header-folding

Conversation

t-8ch commented Jan 9, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.

Fixes #100884

pythonGH-100884: email/_header_value_parser: use existing ListSeparator
b1f41b8 
There already is already a predefined object with the correct
properties, use it.
t-8ch requested a review from a team as a code owner January 9, 2023 13:55
bedevere-bot mentioned this pull request Jan 9, 2023
Closed

bedevere-bot commented Jan 9, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

ghost commented Jan 9, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

pythonGH-100884: email/_header_value_parser: don't encode list separa…
75a89ca 
…tors

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.

Fixes python#100884
serhiy-storchaka approved these changes Feb 17, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

serhiy-storchaka enabled auto-merge (squash) February 17, 2024 09:56
serhiy-storchaka enabled auto-merge (squash) February 17, 2024 09:57
serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 17, 2024
serhiy-storchaka merged commit 09fab93 into python:main Feb 17, 2024

miss-islington-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

Thanks @t-8ch for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2024
pythongh-100884: email/_header_value_parser: don't encode list separa…
5f617f2 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>

bedevere-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

GH-115592 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 17, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2024
pythongh-100884: email/_header_value_parser: don't encode list separa…
a2640a5 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>

bedevere-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

GH-115593 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 17, 2024
serhiy-storchaka pushed a commit that referenced this pull request Feb 17, 2024
[3.12] gh-100884: email/_header_value_parser: don't encode list separ…
9148b77 
…ators (GH-100885) (GH-115592)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>
serhiy-storchaka pushed a commit that referenced this pull request Feb 17, 2024
[3.11] gh-100884: email/_header_value_parser: don't encode list separ…
70754d2 
…ators (GH-100885) (GH-115593)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
pythongh-100884: email/_header_value_parser: don't encode list separa…
90daba0 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
pythongh-100884: email/_header_value_parser: don't encode list separa…
8b88128 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
mgmacias95 mentioned this pull request May 6, 2024
Closed

pablogsal commented May 10, 2024

Copy link
Copy Markdown
Member

@t-8ch @serhiy-storchaka can you take a look at #118643? Seems that this commit may have introduced a regression

LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
pythongh-100884: email/_header_value_parser: don't encode list separa…
f306be6 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
medmunds mentioned this pull request Feb 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

topic-email

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

email: address list folding encodes list-separator comma

5 participants

Back | FazBrowse Home | New Git URL