FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-100942: Fix incorrect cast in property_copy(). by rhettinger · Pull Request #100965 · python/cpython · GitHub

/ cpython Public

GH-100942: Fix incorrect cast in property_copy(). - #100965

Merged
rhettinger merged 2 commits into
python:mainfrom
rhettinger:weird_property_crasher
Jan 12, 2023
ConversationCommits (2)ChecksFiles changed
Merged

GH-100942: Fix incorrect cast in property_copy().#100965
rhettinger merged 2 commits into
python:mainfrom
rhettinger:weird_property_crasher

Conversation

rhettinger commented Jan 12, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

rhettinger added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 12, 2023
bedevere-bot mentioned this pull request Jan 12, 2023
Closed
sobolevn approved these changes Jan 12, 2023
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, nice to see that my idea in #100955 was correct.
I will close mine, since you probably haven't seen it :)

Comment thread Lib/test/test_property.py
pass

p = property.__new__(pro)
p.__set_name__(A, 1)

sobolevn Jan 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This line is not really required. Segfault happens and without it.

rhettinger Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I prefer to leave it because it covers an additional code path that could fail and it is an accurate record of how the issue was discovered.

sobolevn added type-crash A hard crash of the interpreter, possibly with a core dump and removed type-bug An unexpected behavior, bug, or error labels Jan 12, 2023
rhettinger merged commit 94fc770 into python:main Jan 12, 2023

miss-islington commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Sorry, @rhettinger, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 94fc7706b7bc3d57cdd6d15bf8e8c4499ae53a69 3.11

miss-islington commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Sorry @rhettinger, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 94fc7706b7bc3d57cdd6d15bf8e8c4499ae53a69 3.10

rhettinger commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

@sobolevn Would you like to take care of the backport. This PR won't apply cleanly and needs to be recreated for 3.11 and prior.

sobolevn commented Jan 12, 2023

Copy link
Copy Markdown
Member

Yeah, why not :)
Will do soon!

sobolevn pushed a commit to sobolevn/cpython that referenced this pull request Jan 13, 2023
[3.11] pythonGH-100942: Fix incorrect cast in property_copy(). (pytho…
e42fbf0 
…nGH-100965).

(cherry picked from commit 94fc770)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>

bedevere-bot commented Jan 13, 2023

Copy link
Copy Markdown

GH-101008 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 13, 2023
sobolevn pushed a commit to sobolevn/cpython that referenced this pull request Jan 13, 2023
[3.10] pythonGH-100942: Fix incorrect cast in property_copy(). (pytho…
4871a93 
…nGH-100965).

(cherry picked from commit 94fc770)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>

bedevere-bot commented Jan 13, 2023

Copy link
Copy Markdown

GH-101009 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 13, 2023

sobolevn commented Jan 13, 2023

Copy link
Copy Markdown
Member

Done!

kumaraditya303 pushed a commit that referenced this pull request Jan 15, 2023
[3.11] GH-100942: Fix incorrect cast in property_copy(). (GH-100965). (…
855b1a9 
…#101008)

(cherry picked from commit 94fc770)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
kumaraditya303 pushed a commit that referenced this pull request Jan 15, 2023
[3.10] GH-100942: Fix incorrect cast in property_copy(). (GH-100965). (…
b7b641a 
…#101009)

(cherry picked from commit 94fc770)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn approved these changes

Assignees

rhettinger

Labels

type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL