FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101056: Fix memory leak in `formatfloat()` in `bytesobject.c` by sobolevn · Pull Request #101057 · python/cpython · GitHub

/ cpython Public

gh-101056: Fix memory leak in formatfloat() in bytesobject.c - #101057

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
sobolevn:issue-101056
Jan 16, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-101056: Fix memory leak in formatfloat() in bytesobject.c#101057
kumaraditya303 merged 1 commit into
python:mainfrom
sobolevn:issue-101056

Conversation

sobolevn commented Jan 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Docs say:

The return value is a pointer to *buffer* with the converted string or
   ``NULL`` if the conversion failed. The caller is responsible for freeing the
   returned string by calling :c:func:`PyMem_Free`.

bedevere-bot mentioned this pull request Jan 15, 2023
Closed
mdickinson approved these changes Jan 15, 2023
View reviewed changes

mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Probably worth running the buildbots on this, though.

mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 15, 2023

bedevere-bot commented Jan 15, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 8e1b415 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 15, 2023
kumaraditya303 merged commit b1a74a1 into python:main Jan 16, 2023
kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 16, 2023

miss-islington commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot commented Jan 16, 2023

Copy link
Copy Markdown

GH-101076 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2023
pythongh-101056: Fix memory leak in formatfloat() in bytesobject.c (
e9cc8a8 
pythonGH-101057)

(cherry picked from commit b1a74a1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Jan 16, 2023

Copy link
Copy Markdown

GH-101077 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2023
pythongh-101056: Fix memory leak in formatfloat() in bytesobject.c (
9d7c1e4 
pythonGH-101057)

(cherry picked from commit b1a74a1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 16, 2023
gh-101056: Fix memory leak in formatfloat() in bytesobject.c (GH-…
63690e9 
…101057)

(cherry picked from commit b1a74a1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 16, 2023
gh-101056: Fix memory leak in formatfloat() in bytesobject.c (GH-…
664141e 
…101057)

(cherry picked from commit b1a74a1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes
+1 more reviewer
mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL