FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-74185: repr() of ImportError now contains attributes name and path. by serhiy-storchaka · Pull Request #1011 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-74185: repr() of ImportError now contains attributes name and path. - #1011

Closed
serhiy-storchaka wants to merge 9 commits into
python:mainfrom
serhiy-storchaka:importerror-repr
ConversationCommits (9)ChecksFiles changed
Closed

gh-74185: repr() of ImportError now contains attributes name and path.#1011
serhiy-storchaka wants to merge 9 commits into
python:mainfrom
serhiy-storchaka:importerror-repr

Conversation

serhiy-storchaka commented Apr 5, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added the type-feature A feature request or enhancement label Apr 7, 2017
auvipy suggested changes May 31, 2019
View reviewed changes

auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

re base plz

github-actions Bot commented Feb 19, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022

github-actions Bot commented Aug 28, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022
serhiy-storchaka mentioned this pull request Oct 29, 2022
Closed
iritkatriel previously requested changes Nov 29, 2022
View reviewed changes

iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This has merge conflicts now.

bedevere-bot commented Nov 29, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 30, 2022

github-actions Bot commented Dec 31, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 31, 2022
arhadthedev changed the title bpo-29999: repr() of ImportError now contains attributes name and path. gh-74185: repr() of ImportError now contains attributes name and path. Feb 13, 2023
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Apr 6, 2023

github-actions Bot commented May 11, 2023

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label May 11, 2023
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jan 6, 2024

github-actions Bot commented Feb 5, 2024

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 5, 2024

MuhammadTausif commented Aug 9, 2024

Copy link
Copy Markdown

Why this PR is still open?

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 9, 2024

github-actions Bot commented Sep 8, 2024

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 8, 2024

encukou commented Dec 19, 2024

Copy link
Copy Markdown
Member

@serhiy-storchaka, do you want to finish this PR? Should I take over?

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 19, 2024

github-actions Bot commented Jan 19, 2025

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 19, 2025

auvipy commented Feb 13, 2025

Copy link
Copy Markdown

@serhiy-storchaka, do you want to finish this PR? Should I take over?

I think you should take it over now

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 13, 2025

github-actions Bot commented Mar 15, 2025

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 15, 2025

This comment was marked as abuse.

Sign in to view
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Apr 23, 2025
johnzhou721 approved these changes May 18, 2025
View reviewed changes
Comment thread Lib/test/test_exceptions.py
exc = ImportError('test', name='somename', path='somepath')
self.assertEqual(repr(exc),
"ImportError('test', name='somename', path='somepath')")

johnzhou721 May 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure, but we might want a test that actually tries importing some nonexistent module and see if its __repr__ has those required attributes.

github-actions Bot commented Jun 18, 2025

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 18, 2025
Yoav11 mentioned this pull request Jul 19, 2025
Merged
serhiy-storchaka deleted the importerror-repr branch August 14, 2025 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou left review comments
ezio-melotti ezio-melotti left review comments
furkanonder furkanonder approved these changes
iritkatriel iritkatriel left review comments
+2 more reviewers
auvipy auvipy requested changes
johnzhou721 johnzhou721 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL