FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98831: register instructions have 0 pushes and pops by iritkatriel · Pull Request #101163 · python/cpython · GitHub

/ cpython Public

gh-98831: register instructions have 0 pushes and pops - #101163

Merged
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:metadata
Jan 19, 2023
Merged

gh-98831: register instructions have 0 pushes and pops#101163
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:metadata

Conversation

iritkatriel commented Jan 19, 2023
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good call!

Maybe it's time to add some tests for the generated opcode metadata (but I'm not asking for that now).

Copy link
Copy Markdown
Member Author

It failed very quickly when I tried to use it (the sanity check we added in the compiler flipped).

gvanrossum commented Jan 19, 2023
edited
Loading

Copy link
Copy Markdown
Member

Is it ready to merge?

Note: there are other things in the generator that probably don't work, e.g. there are some commented-out out.emit(f"JUMPBY(OPSIZE(... calls. But those might be not needed if we go ahead with the variable-length scheme.

Copy link
Copy Markdown
Member Author

Is it ready to merge?

I think so.

Note: there are other things in the generator that probably don't work, e.g. there are some commented-out out.emit(f"JUMPBY(OPSIZE(... calls. But those might be not needed if we go ahead with the variable-length scheme.

I'm not doing variable length instructions now. I'm adding the plumbing in the compiler, and for now supporting only 1 oparg (so I can do RETURN_VALUE from a tmp register). There's plenty there to keep me busy for now.

iritkatriel merged commit 8a2d4f4 into python:main Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL