GH-92123: Store _elementtree state in type contexts - #101190
Merged
erlend-aasland merged 2 commits intoJan 23, 2023
Merged
Conversation
This comment was marked as outdated.
erlend-aasland
force-pushed
the
etree/state-as-type-context-member
branch
from
b1127be to
b2698e2
Compare
January 21, 2023 11:32
erlend-aasland
force-pushed
the
etree/state-as-type-context-member
branch
from
007ccb5 to
4f0f2ff
Compare
January 22, 2023 11:43
Copy link
Copy Markdown
Contributor
Author
|
How about this: we store state in the type context for the TreeBuilder and XMLParser. The state pointer should be valid throughout the lifetime of the heap type, since each heap type has a reference to its module. After landing this, I'll rebase #101189 onto main. |
Sorry, something went wrong.
kumaraditya303
approved these changes
Jan 23, 2023
kumaraditya303
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.