gh-92123: Adapt _elementtree to multi-phase init (PEP 489) - #101285
Merged
erlend-aasland merged 28 commits intoJan 24, 2023
Merged
gh-92123: Adapt _elementtree to multi-phase init (PEP 489)#101285erlend-aasland merged 28 commits into
erlend-aasland merged 28 commits into
Conversation
Pass state as arg to expat_set_error()
Pass state as arg to element_setstate_from_attributes()
Pass state as arg to element_setstate_from_Python()
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit de8ec94 🤖 If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again. |
Sorry, something went wrong.
corona10
approved these changes
Jan 24, 2023
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Code change iteself looks good to me.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Thanks for the review; I'll merge as soon as the CI turns green. I'll give Kumar a chance to review it, so I'll wait with merging until tomorrow evening. |
Sorry, something went wrong.
kumaraditya303
approved these changes
Jan 24, 2023
Copy link
Copy Markdown
Member
|
Nicely done @erlend-aasland, that was a big one! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.