FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98831: rewrite RAISE_VARARGS in the instruction definition DSL by iritkatriel · Pull Request #101306 · python/cpython · GitHub

/ cpython Public

gh-98831: rewrite RAISE_VARARGS in the instruction definition DSL - #101306

Merged
iritkatriel merged 7 commits into
python:mainfrom
iritkatriel:RAISE_VARARG
Jan 25, 2023
ConversationCommits (7)ChecksFiles changed
Merged

gh-98831: rewrite RAISE_VARARGS in the instruction definition DSL#101306
iritkatriel merged 7 commits into
python:mainfrom
iritkatriel:RAISE_VARARG

Conversation

iritkatriel commented Jan 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Jan 25, 2023
Closed
iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 25, 2023

bedevere-bot commented Jan 25, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 7fe1602 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 25, 2023
iritkatriel commented Jan 25, 2023
View reviewed changes
Comment thread Python/generated_cases.c.h Outdated
gvanrossum reviewed Jan 25, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(Seems I forgot to send one comment.)

Comment thread Python/bytecodes.c Outdated
Comment thread Python/generated_cases.c.h Outdated
gvanrossum reviewed Jan 25, 2023
View reviewed changes
Comment thread Tools/cases_generator/test_generator.py
Comment on lines +346 to +347
PyObject *arg1 = PEEK(1);
PyObject *interim;

gvanrossum Jan 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Note that if you run the tests it'll fail here. I accidentally hit return in the middle of this line and didn't re-run these tests before pushing. As these tests aren't run automatically yet this didn't trigger any CI failures. :-(

I'll fix it in my next change to this file, but I figured I'd warn you.

iritkatriel Jan 25, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ok. I also made a mess of my branch just now. Will fix in a bit.

iritkatriel Jan 25, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We also need to update the makefile. Currently when I change the opcode_metadata.h file I need to touch compile.c. I had a look but wasn't sure what to change.

iritkatriel merged commit b400219 into python:main Jan 25, 2023
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
pythongh-98831: rewrite RAISE_VARARGS in the instruction definition D…
16695a0 
…SL (python#101306)
iritkatriel deleted the RAISE_VARARG branch April 3, 2023 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
1st1 Awaiting requested review from 1st1
asvetlov Awaiting requested review from asvetlov
kumaraditya303 Awaiting requested review from kumaraditya303

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL