gh-98831: Modernize CALL_FUNCTION_EX - #101627
Merged
gvanrossum merged 3 commits intoFeb 8, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
iritkatriel
reviewed
Feb 7, 2023
Comment thread
Python/generated_cases.c.h
Copy link
Copy Markdown
Member
Author
|
On top of that the tests fail. Going back into draft mode. |
Sorry, something went wrong.
gvanrossum
marked this pull request as draft
February 7, 2023 05:18
Also avoid compiler warning for unused variable 'null' (used in assert only).
gvanrossum
force-pushed
the
call-function-ex
branch
from
10dcbec to
19307ba
Compare
February 7, 2023 20:28
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 19307ba 🤖 If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again. |
Sorry, something went wrong.
gvanrossum
marked this pull request as ready for review
February 7, 2023 21:59
Copy link
Copy Markdown
Member
Author
|
@iritkatriel Crash fixed, warning fixed, tests passed, refleak buildbots are running. Ready for your review. |
Sorry, something went wrong.
iritkatriel
approved these changes
Feb 7, 2023
Copy link
Copy Markdown
Member
Author
|
I'm taking the PPC64LE RHEL8 Refleaks PR buildbot failure as a flake. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a straightforward use of a conditional input stack effect. The one tricky bit is that I had to cherry-pick a fix for CHECK_EVAL_BREAKER() from gh-101508. Whichever lands first, the other will have to drop that commit.