gh-98831: rewrite UNPACK_EX, UNPACK_SEQUENCE, UNPACK_SEQUENCE_TWO_TUPLE in the instruction definition DSL - #101641
Merged
iritkatriel merged 4 commits intoFeb 7, 2023
Merged
Conversation
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit e0accbb 🤖 If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again. |
Sorry, something went wrong.
gvanrossum
approved these changes
Feb 7, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Shouldn't you also move the family declaration in front of the first instruction of the family? (Where that family is now is effectively commented-out.)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LG, I'll take care of the family when I do UNPACK_SEQUENCE_{TUPLE,LIST}. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.