FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101446: Change `repr` of `collections.OrderedDict` by sobolevn · Pull Request #101661 · python/cpython · GitHub

/ cpython Public

gh-101446: Change repr of collections.OrderedDict - #101661

Merged
rhettinger merged 4 commits into
python:mainfrom
sobolevn:issue-101446
Feb 8, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-101446: Change repr of collections.OrderedDict#101661
rhettinger merged 4 commits into
python:mainfrom
sobolevn:issue-101446

Conversation

sobolevn commented Feb 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Now it is:

>>> from collections import OrderedDict
>>> OrderedDict({1: 'a', 2: 'b'})
OrderedDict({1: 'a', 2: 'b'})

Openning this as a draft to see what tests will fail :)

bedevere-bot mentioned this pull request Feb 7, 2023
Closed
sobolevn marked this pull request as ready for review February 7, 2023 21:29
sobolevn requested a review from rhettinger as a code owner February 7, 2023 21:29
rhettinger merged commit 790ff6b into python:main Feb 8, 2023

Gouvernathor commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Out of curiosity, why not using super().repr() instead of recreating a whole new dict ? Wouldn't it save quite some time ?

jacobtylerwalls mentioned this pull request May 10, 2023
Closed
musicinmybrain added a commit to musicinmybrain/glymur that referenced this pull request Jul 11, 2023
Adapt to OrderedDict repr change in Python 3.12
5cd1c93 
python/cpython#101661
musicinmybrain mentioned this pull request Jul 11, 2023
Closed
jeertmans mentioned this pull request Oct 23, 2023
Merged
1 task
Linchin mentioned this pull request Dec 1, 2023
Merged
XuehaiPan mentioned this pull request Apr 4, 2024
Merged
12 tasks
kounelisagis mentioned this pull request May 8, 2024
Merged
This was referenced Jul 12, 2024
Open
Open
randomir mentioned this pull request Dec 5, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL