FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] gh-100933: Improve `check_element` helper in `test_xml_etree` (GH-100934) by miss-islington · Pull Request #101686 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.11] gh-100933: Improve check_element helper in test_xml_etree (GH-100934) #101686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 1 commit into from
Feb 8, 2023
Conversation 0 Commits 1 Checks 0 Files changed
Merged

[3.11] gh-100933: Improve check_element helper in test_xml_etree (GH-100934) #101686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
27 changes: 4 additions & 23 deletions Lib/test/test_xml_etree.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -203,25 +203,6 @@ def serialize_check(self, elem, expected):
def test_interface(self):
# Test element tree interface.

def check_string(string):
len(string)
for char in string:
self.assertEqual(len(char), 1,
msg="expected one-character string, got %r" % char)
new_string = string + ""
new_string = string + " "
string[:0]

def check_mapping(mapping):
len(mapping)
keys = mapping.keys()
items = mapping.items()
for key in keys:
item = mapping[key]
mapping["key"] = "value"
self.assertEqual(mapping["key"], "value",
msg="expected value string, got %r" % mapping["key"])

def check_element(element):
self.assertTrue(ET.iselement(element), msg="not an element")
direlem = dir(element)
Expand All @@ -231,12 +212,12 @@ def check_element(element):
self.assertIn(attr, direlem,
msg='no %s visible by dir' % attr)

check_string(element.tag)
check_mapping(element.attrib)
self.assertIsInstance(element.tag, str)
self.assertIsInstance(element.attrib, dict)
if element.text is not None:
check_string(element.text)
self.assertIsInstance(element.text, str)
if element.tail is not None:
check_string(element.tail)
self.assertIsInstance(element.tail, str)
for elem in element:
check_element(elem)

Expand Down
Back | FazBrowse Home | New Git URL