FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) by miss-islington · Pull Request #101711 · python/cpython · GitHub

/ cpython Public

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) - #101711

Merged
miss-islington merged 2 commits into
python:3.11from
miss-islington:backport-23751ed-3.11
Feb 8, 2023
ConversationCommits (2)ChecksFiles changed
Merged

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286)#101711
miss-islington merged 2 commits into
python:3.11from
miss-islington:backport-23751ed-3.11

Conversation

miss-islington commented Feb 8, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin oleg@arhadthedev.net

pythongh-101283: Improved fallback logic for subprocess with shell=Tr…
644134d 
…ue on Windows (pythonGH-101286)

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
This was referenced Feb 8, 2023
Closed
Merged
bedevere-bot added the type-security A security issue label Feb 8, 2023
zooba reviewed Feb 8, 2023
View reviewed changes
Comment thread Lib/subprocess.py
gpshead requested changes Feb 8, 2023
View reviewed changes
Comment thread Doc/library/subprocess.rst
Added the *text* parameter, as a more understandable alias of *universal_newlines*.
Added the *capture_output* parameter.

.. versionchanged:: 3.11.2

gpshead Feb 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this version number is wrong everywhere. 3.11.2 was just released.

bedevere-bot commented Feb 8, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

zooba approved these changes Feb 8, 2023
View reviewed changes
Comment thread Doc/library/subprocess.rst
Added the *text* parameter, as a more understandable alias of *universal_newlines*.
Added the *capture_output* parameter.

.. versionchanged:: 3.11.2

zooba Feb 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
.. versionchanged:: 3.11.2
.. versionchanged:: 3.11.3

Comment thread Doc/library/subprocess.rst
*executable* parameter accepts a bytes and :term:`path-like object`
on Windows.

.. versionchanged:: 3.11.2

zooba Feb 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
.. versionchanged:: 3.11.2
.. versionchanged:: 3.11.3

Comment thread Doc/library/subprocess.rst
.. versionchanged:: 3.3
*timeout* was added.

.. versionchanged:: 3.11.2

zooba Feb 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
.. versionchanged:: 3.11.2
.. versionchanged:: 3.11.3

Comment thread Doc/library/subprocess.rst
.. versionchanged:: 3.3
*timeout* was added.

.. versionchanged:: 3.11.2

zooba Feb 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
.. versionchanged:: 3.11.2
.. versionchanged:: 3.11.3

Comment thread Doc/library/subprocess.rst
.. versionadded:: 3.7
*text* was added as a more readable alias for *universal_newlines*.

.. versionchanged:: 3.11.2

zooba Feb 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
.. versionchanged:: 3.11.2
.. versionchanged:: 3.11.3

miss-islington merged commit 51b079a into python:3.11 Feb 8, 2023
miss-islington deleted the backport-23751ed-3.11 branch February 8, 2023 23:44

zooba commented Feb 8, 2023

Copy link
Copy Markdown
Member

Whoops 😆 Forgot that hitting approve would merge it immediately

#101719 will backport to it at least

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead requested changes
zooba zooba approved these changes

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL