FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) by zooba · Pull Request #101713 · python/cpython · GitHub

/ cpython Public

[3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) - #101713

Merged
ambv merged 2 commits into
python:3.7from
zooba:gh-101283-3.7
Feb 9, 2023
ConversationCommits (2)ChecksFiles changed
Merged

[3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286)#101713
ambv merged 2 commits into
python:3.7from
zooba:gh-101283-3.7

Conversation

zooba commented Feb 8, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

zooba requested a review from gpshead as a code owner February 8, 2023 22:36
bedevere-bot mentioned this pull request Feb 8, 2023
Closed
zooba changed the title gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) [3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) Feb 8, 2023
bedevere-bot mentioned this pull request Feb 8, 2023
Merged
bedevere-bot added the type-security A security issue label Feb 8, 2023

zooba commented Feb 8, 2023

Copy link
Copy Markdown
Member Author

macOS crash is due to underlying OS update and not related to this PR.

arhadthedev marked this pull request as draft February 9, 2023 03:38

arhadthedev commented Feb 9, 2023

Copy link
Copy Markdown
Member

Undrafting since the introduced bug will be fixed separately by backports of gh-101712. My apologizes for the confusion; I didn't sort out my incoming notifications timely.

arhadthedev marked this pull request as ready for review February 9, 2023 06:15
arhadthedev reviewed Feb 9, 2023
View reviewed changes
Comment thread Doc/library/subprocess.rst
Comment on lines +453 to +454
.. versionchanged:: 3.6
*executable* parameter accepts a :term:`path-like object` on POSIX.

arhadthedev Feb 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Was it added by mistake?

ambv Feb 9, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It was probably added to resolve the conflict but it belongs in the 3.7 docs as well. For some reason this doc bit wasn't ported back to 3.6 and 3.7 when Serhiy landed GH-5914.

I would leave it in.

arhadthedev reviewed Feb 9, 2023
View reviewed changes

arhadthedev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

According to https://www.python.org/downloads/ the next published 3.7 release will be 3.7.17.

Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated
Apply suggestions from code review
3196632 
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
ambv merged commit c7fdc9c into python:3.7 Feb 9, 2023
zooba deleted the gh-101283-3.7 branch February 9, 2023 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv left review comments
arhadthedev arhadthedev left review comments
gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL