FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-71587: Clear cached strptime module by abalkin · Pull Request #101783 · python/cpython · GitHub

/ cpython Public

gh-71587: Clear cached strptime module - #101783

Closed
abalkin wants to merge 2 commits into
python:mainfrom
abalkin:gh-71587
ConversationCommits (2)ChecksFiles changed
Closed

gh-71587: Clear cached strptime module#101783
abalkin wants to merge 2 commits into
python:mainfrom
abalkin:gh-71587

Conversation

abalkin commented Feb 10, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

abalkin self-assigned this Feb 10, 2023
bedevere-bot mentioned this pull request Feb 10, 2023
Closed

ghost commented Feb 10, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:

abalkin commented Feb 10, 2023
View reviewed changes
Comment thread Modules/_datetimemodule.c Outdated
}

static void module_free(void*) {
strptime_module = NULL;

abalkin Feb 10, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should call Py_CLEAR here to avoid leaking a reference.

abalkin linked an issue Feb 10, 2023 that may be closed by this pull request
Datetime NoneType after calling Py_Finalize and Py_Initialize #71587
Closed

zooba commented Feb 10, 2023

Copy link
Copy Markdown
Member

This approach isn't going to be any better than the existing one. It needs to be written in a way that doesn't use global variables at all (static inside a function is effectively a global variable).

StanFromIreland commented Mar 8, 2025

Copy link
Copy Markdown
Member

This can be closed, the issue is complete.

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

StanFromIreland commented Jul 29, 2025

Copy link
Copy Markdown
Member

Closing as this has been completed.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pganssle Awaiting requested review from pganssle pganssle will be requested when the pull request is marked ready for review pganssle is a code owner
StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland will be requested when the pull request is marked ready for review StanFromIreland is a code owner

Assignees

abalkin

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Datetime NoneType after calling Py_Finalize and Py_Initialize

5 participants

Back | FazBrowse Home | New Git URL