FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101821: Cover `ast.main` function by sobolevn · Pull Request #101822 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101821: Cover ast.main function - #101822

Merged
hauntsaninja merged 1 commit into
python:mainfrom
sobolevn:issue-101821
Mar 11, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-101821: Cover ast.main function#101822
hauntsaninja merged 1 commit into
python:mainfrom
sobolevn:issue-101821

Conversation

sobolevn commented Feb 11, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Couple of comments on the implementation:

  • script_helper.run_python_until_end has @support.requires_subprocess() guard, so it is should be safe for envs where subprocess is not available
  • os_helper.temp_dir is also widely used for temp files, it even catches OSError and warns about it

So, this new cases should not add any test falkiness or new failures 🙂

sobolevn requested a review from isidentical February 11, 2023 10:13
bedevere-bot mentioned this pull request Feb 11, 2023
Closed
bedevere-bot added the tests Tests in the Lib/test dir label Feb 11, 2023

sobolevn commented Feb 11, 2023

Copy link
Copy Markdown
Member Author

Oh, \n is platform specific. Fixing!

arhadthedev reviewed Feb 11, 2023
View reviewed changes
Comment thread Lib/test/test_ast.py Outdated
sobolevn requested a review from hauntsaninja March 11, 2023 11:41

sobolevn commented Mar 11, 2023

Copy link
Copy Markdown
Member Author

@hauntsaninja can you please take a look? :)

hauntsaninja approved these changes Mar 11, 2023
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Weird that the default indentation is 3

hauntsaninja merged commit bb396ee into python:main Mar 11, 2023

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @hauntsaninja, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bb396eece44036a71427e7766fbb8e0247373102 3.11

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Sorry @sobolevn and @hauntsaninja, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker bb396eece44036a71427e7766fbb8e0247373102 3.10

hauntsaninja commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Thanks! Fine not to backport since there are already merge conflicts

iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Mar 12, 2023
pythongh-101821: Test coverage for ast.main function (python#101822)
f955ac9
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
pythongh-101821: Test coverage for ast.main function (python#101822)
76610db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

arhadthedev arhadthedev left review comments
hauntsaninja hauntsaninja approved these changes
isidentical Awaiting requested review from isidentical

Assignees

hauntsaninja

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL