gh-85984: Major revision of the pty library. - #101833
Draft
8vasu wants to merge 2 commits into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Soumendra Ganguly <soumendraganguly@gmail.com>
This was referenced Feb 11, 2023
Copy link
Copy Markdown
Contributor
Author
|
@gpshead This is the main set of changes in this series, but it will not work without |
Sorry, something went wrong.
8vasu
commented
Feb 11, 2023
Comment thread
Lib/pty.py
| fds = [master_fd, STDIN_FILENO] | ||
| while fds: | ||
| rfds, _wfds, _xfds = select(fds, [], []) | ||
| while True: |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I do not think that fds is ever empty in this loop. Therefore, I replaced while fds: with the original while True:. Please correct me if I am wrong.
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #92365. This is one in a series of PRs aimed at cleaning-up, fixing bugs in, introducing new features in, and updating the code in "Lib/pty.py".
This is expected to fail before the following prerequisites are merged: #101832 and #102413.
Signed-off-by: Soumendra Ganguly soumendraganguly@gmail.com