FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101754: document that on Windows, keys in `os.environ` are converted to uppercase by OTheDev · Pull Request #101840 · python/cpython · GitHub

/ cpython Public

gh-101754: document that on Windows, keys in os.environ are converted to uppercase - #101840

Merged
zooba merged 2 commits into
python:mainfrom
OTheDev:fix-issue-101754
Mar 3, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-101754: document that on Windows, keys in os.environ are converted to uppercase#101840
zooba merged 2 commits into
python:mainfrom
OTheDev:fix-issue-101754

Conversation

OTheDev commented Feb 12, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Feb 12, 2023
Closed
bedevere-bot added docs Documentation in the Doc dir skip news labels Feb 12, 2023
brettcannon requested a review from zooba March 2, 2023 00:35

zooba commented Mar 2, 2023

Copy link
Copy Markdown
Member

Looks fine. I think we can move it up to just below the "On Unix" paragraph that talks about encodings. The uppercasing is handled in roughly the same way that the encoding is, so may as well be presented at the same level.

OTheDev commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @zooba, I've moved it to a new paragraph just below the "On Unix" one. Here's how it looks now

Please let me know if there is anything else :)

zooba merged commit 4e7c0cb into python:main Mar 3, 2023

zooba commented Mar 3, 2023

Copy link
Copy Markdown
Member

That's great, thanks!

zooba added OS-windows needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 3, 2023

miss-islington commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @OTheDev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @OTheDev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot commented Mar 3, 2023

Copy link
Copy Markdown

GH-102393 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2023
pythongh-101754: Document that Windows converts keys in os.environ …
755862e 
…to uppercase (pythonGH-101840)

(cherry picked from commit 4e7c0cb)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>

bedevere-bot commented Mar 3, 2023

Copy link
Copy Markdown

GH-102394 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2023
pythongh-101754: Document that Windows converts keys in os.environ …
6082c4f 
…to uppercase (pythonGH-101840)

(cherry picked from commit 4e7c0cb)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 3, 2023
gh-101754: Document that Windows converts keys in os.environ to upp…
3d88b4e 
…ercase (GH-101840)

(cherry picked from commit 4e7c0cb)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 3, 2023
gh-101754: Document that Windows converts keys in os.environ to upp…
32a738e 
…ercase (GH-101840)

(cherry picked from commit 4e7c0cb)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull request Mar 4, 2023
Merge branch 'main' into nodeaddict
a31af32 
* main:
  pythongh-102021 : Allow multiple input files for interpreter loop generator (python#102022)
  Add import of `unittest.mock.Mock` in documentation (python#102346)
  pythongh-102383: [docs] Arguments of `PyObject_CopyData` are `PyObject *` (python#102390)
  pythongh-101754: Document that Windows converts keys in `os.environ` to uppercase (pythonGH-101840)
  pythongh-102324: Improve tests of `typing.override` (python#102325)
OTheDev deleted the fix-issue-101754 branch January 28, 2025 03:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

docs Documentation in the Doc dir OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document that os.environ forcibly upper-cases keys on case-insensitive OSs

4 participants

Back | FazBrowse Home | New Git URL