| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
BTW, it allows to close gh-32135 as outdated. |
Sorry, something went wrong.
|
@rhettinger had some opinion on this as well. |
Sorry, something went wrong.
|
Sad to see Håvamål go 😢👁️ cpython/Tools/iobench/iobench.py Lines 482 to 548 in 81e3aa8 |
Sorry, something went wrong.
|
(Resolved conflict) |
Sorry, something went wrong.
|
I would have commented sooner had I known that this was about to happen. It would have been helpful if someone had commented in my PR to ccbench.py that this was being considered so that I would have been notified and might have had a chance to comment before it happened. I believe it was clear from the extensive discussion about the shortcomings of the current GIL in faster-cpython that the ccbench script is still useful - because it clearly identifies an ongoing performance issue when multithreading with one or more CPU-heavy threads. That said, I do understand that performance scripts do not really have a place in the cpython source code repo, but unfortunately I do not have the time to rework the updated ccbench script for the pyperformance suite, so I guess it is going to just disappear. |
Sorry, something went wrong.
Apologies, I'll ping next time this sort of thing comes up. (btw we wouldn't be allowed to merge your PR because it looks like the CLA isn't signed.)
Yep, in general, benchmarks are much more useful in pyperformace, because they're run often and people pay attention to their results. The code hasn't disappeared, it's still in the 3.12 and older branches, and in Git history. And of course, if there's consensus we can easily revert/re-add bits of this. |
Sorry, something went wrong.
Go look at the PR history - I signed the CLA and the relevant label was added. Later the label was removed for some reason unknown to me.. |
Sorry, something went wrong.
…1853) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…1853) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…1853) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
Closes #32135.
Closes #100176.
Closes #100197.
See:
Replaces and: