gh-101860: Expose __name__ on property - #101876
Merged
serhiy-storchaka merged 4 commits intoFeb 20, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
eltoder
force-pushed
the
feature/property-name
branch
3 times, most recently
from
05db108 to
9c956c7
Compare
February 13, 2023 18:00
Copy link
Copy Markdown
Member
|
@eltoder, there are a lot of conflicts now. Could you please update the branch? |
Sorry, something went wrong.
serhiy-storchaka
self-requested a review
February 17, 2024 08:17
Useful for introspection and consistent with functions and other descriptors.
eltoder
force-pushed
the
feature/property-name
branch
from
9c956c7 to
8ec1251
Compare
February 17, 2024 15:59
Copy link
Copy Markdown
Member
|
Thank you. I knew I could count on you. |
Sorry, something went wrong.
Comment thread
Lib/inspect.py
Comment thread
Doc/howto/descriptor.rst
Outdated
Comment thread
Objects/descrobject.c
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@serhiy-storchaka I made __name__ default to fget.__name__ when possible. What do you think? |
Sorry, something went wrong.
Raise AttributeError if no fget or it doesn't have `__name__`.
eltoder
force-pushed
the
feature/property-name
branch
from
732337d to
c20e9a7
Compare
February 20, 2024 04:40
serhiy-storchaka
approved these changes
Feb 20, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. And I like to to review more of your PRs.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you! |
Sorry, something went wrong.
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
Useful for introspection and consistent with functions and other descriptors.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Useful for introspection and consistent with functions and other descriptors.
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
Useful for introspection and consistent with functions and other descriptors.
dangotbanned
added a commit
to narwhals-dev/narwhals
that referenced
this pull request
Apr 23, 2025
Following where `__name__` used to be sourced from - python/cpython#101876
MarcoGorelli
pushed a commit
to narwhals-dev/narwhals
that referenced
this pull request
Apr 26, 2025
* chore(typing): fix `check_docstrings` `Path` warning `pyright` did a good job spotting that one * chore: Use `dir(...)` instead of `.__dir__()` Fixes 2/6 errors and shrinks the script * chore(typing): Fix 2 more errors These have been popping up and bugging me for 2 weeks 🙈 #2351 (comment) * chore(typing): Fix the last 2 as well * chore: Simplify the rest * chore(typing): Ignore remaining in `utils` * chore(typing): Ignore everything in `tpch` These are all the same issue, can be fixed with a constrained `TypeVar` * fix: pre-`3.13` compat? Following where `__name__` used to be sourced from - python/cpython#101876 * chore(typing): Fix some of the new `tpch` ignores The rest seem pretty unavoidable * fix: don't clobber `typing` 🤦♂️ https://github.com/narwhals-dev/narwhals/actions/runs/14624570842/job/41032838053?pr=2426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for introspection and consistent with functions and other descriptors.