FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101758: Add a Test For Single-Phase Init Module Variants by ericsnowcurrently · Pull Request #101891 · python/cpython · GitHub

/ cpython Public

gh-101758: Add a Test For Single-Phase Init Module Variants - #101891

Merged
ericsnowcurrently merged 8 commits into
python:mainfrom
ericsnowcurrently:test-legacy-extension-with-state
Feb 14, 2023
ConversationCommits (8)ChecksFiles changed
Merged

gh-101758: Add a Test For Single-Phase Init Module Variants#101891
ericsnowcurrently merged 8 commits into
python:mainfrom
ericsnowcurrently:test-legacy-extension-with-state

Conversation

ericsnowcurrently commented Feb 13, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The new test exercises the most important variants for single-phase init extension modules. We also add some explanation about those variants to import.c.

bedevere-bot mentioned this pull request Feb 13, 2023
Closed
ericsnowcurrently merged commit 096d009 into python:main Feb 14, 2023
ericsnowcurrently deleted the test-legacy-extension-with-state branch February 14, 2023 21:26
ericsnowcurrently mentioned this pull request Feb 16, 2023
Merged
ericsnowcurrently added a commit that referenced this pull request Feb 17, 2023
gh-101758: Fix Refleak-Related Failures in test_singlephase_variants (g…
984f8ab 
…h-101969)

gh-101891 is causing failures under `$> ./python -m test test_imp -R 3:3`.  Furthermore, with that fixed, "test_singlephase_variants" is leaking references.  This change addresses the first part, but skips the leaking tests until we can follow up with a fix.

#101758

gpshead commented Feb 17, 2023

Copy link
Copy Markdown
Member

!buildbot Fedora Stable Refleaks

bedevere-bot commented Feb 17, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b7bf588 🤖

The command will test the builders whose names match following regular expression: Fedora Stable Refleaks

The builders matched are:

gpshead added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023

bedevere-bot commented Feb 17, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b7bf588 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
ericsnowcurrently mentioned this pull request Oct 4, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
encukou Awaiting requested review from encukou
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL