| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Does this work for you, @zooba? Re. #101819 (comment) |
Sorry, something went wrong.
|
Can you remove the Check macro entirely? It's got to go if we're supporting multiple instances of the module, so may as well just go now. I'd kinda like to see a few more tstate parameters being passed around, but I guess if the lower level APIs don't take them then there's nowhere to pass them 🤷♂️ |
Sorry, something went wrong.
The one in PC/_testconsole.c, Python/pylifecycle.c, or both? I assume the assert in Modules/_io/winconsoleio.c should stay. |
Sorry, something went wrong.
|
I was thinking the definition in _iomodule.h and anywhere it's used, but I see now that's fully internal anyway. Provided we're not changing any supported public API, it's fine. |
Sorry, something went wrong.
AFAICS, _iomodule.h is not included in Python.h, so we should be fine. |
Sorry, something went wrong.
|
Perhaps we should wait for #101919 to land, before merging this 😄 cc. @ericsnowcurrently |
Sorry, something went wrong.
|
Don't worry about waiting for that PR to merge. I don't think it conflicts. Regardless, I don't mind fixing my branch if needed. |
Sorry, something went wrong.
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
Status check is done, and it's a success ✅. |
Sorry, something went wrong.
|
Thanks for the reviews; highly appreciated. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Automerge-Triggered-By: GH:erlend-aasland