FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101907: Removes use of non-standard C++ extension from Include/cpython/code.h by zooba · Pull Request #101909 · python/cpython · GitHub

/ cpython Public

gh-101907: Removes use of non-standard C++ extension from Include/cpython/code.h - #101909

Closed
zooba wants to merge 2 commits into
python:mainfrom
zooba:gh-101907
ConversationCommits (2)ChecksFiles changed
Closed

gh-101907: Removes use of non-standard C++ extension from Include/cpython/code.h#101909
zooba wants to merge 2 commits into
python:mainfrom
zooba:gh-101907

Conversation

zooba commented Feb 14, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Updates all references to use the macros, so that changes are localised to the header file.

bedevere-bot mentioned this pull request Feb 14, 2023
Closed

zooba commented Feb 14, 2023

Copy link
Copy Markdown
Member Author

Another possible fix (that I haven't tested yet) would be to move this struct into a private header. I don't have any strong preference, but I'm also not familiar with its background and intended use.

markshannon commented Feb 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This is C11, not C++.

What problem is this causing? Looks like I should have read the issue.

markshannon commented Feb 14, 2023

Copy link
Copy Markdown
Member

Anonymous unions are quite useful, especially for inserting unions into a struct and retaining API compatibility. It's a shame we can't use them.

zooba commented Feb 14, 2023

Copy link
Copy Markdown
Member Author

I agree they're useful, but I don't need to be convinced. We have to win over the C++ committee 😄 And then wait a decade for it to be generally available in all the compilers we support.

Incidentally, I noticed the SET macro, so I fixed it and am switching the assignments to use that.

zooba commented Feb 14, 2023

Copy link
Copy Markdown
Member Author

#101912 is an alternate PR to this one

zooba commented Feb 15, 2023

Copy link
Copy Markdown
Member Author

We prefer #101912

zooba closed this Feb 15, 2023
zooba deleted the gh-101907 branch February 15, 2023 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon Awaiting requested review from markshannon markshannon is a code owner
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL