gh-101578: Amend exception docs - #102057
Merged
erlend-aasland merged 3 commits intoFeb 21, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Follow-up to pythongh-101962
CAM-Gerlach
reviewed
Feb 19, 2023
CAM-Gerlach
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @erlend-aasland ! Just some relatively modest suggestions and comments.
Sorry, something went wrong.
Comment thread
Doc/c-api/exceptions.rst
Outdated
Comment thread
Doc/c-api/exceptions.rst
Outdated
Comment thread
Doc/c-api/exceptions.rst
Outdated
Comment thread
Doc/c-api/exceptions.rst
Outdated
Comment thread
Doc/c-api/exceptions.rst
Outdated
iritkatriel
approved these changes
Feb 20, 2023
CAM-Gerlach
approved these changes
Feb 21, 2023
CAM-Gerlach
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, other than if you want to further revise the PyErr_SetRaisedException section along your previous lines (per comment).
Sorry, something went wrong.
Comment thread
Doc/c-api/exceptions.rst
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Feb 23, 2023
* main: (76 commits) Fix syntax error in struct doc example (python#102160) pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089) pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143) Few coverage nitpicks for the cmath module (python#102067) pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985) pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137) pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356) pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119) pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100) pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009) pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923) pythongh-100556: Improve clarity of `or` docs (python#100589) pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026) pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966) pythongh-101578: Amend exception docs (python#102057) pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) ...
python-sidebar
pushed a commit
to python-sidebar/Python-Documentation-Fork-With-TOC
that referenced
this pull request
Sep 1, 2024
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
python-sidebar
pushed a commit
to python-sidebar/Python-Documentation-Fork-With-TOC
that referenced
this pull request
Sep 1, 2024
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Sep 10, 2024
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to gh-101962