FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.10] gh-101981: Build macOS as recommended by the devguide (GH-102070) by miss-islington · Pull Request #102073 · python/cpython · GitHub

/ cpython Public

[3.10] gh-101981: Build macOS as recommended by the devguide (GH-102070) - #102073

Merged
erlend-aasland merged 1 commit into
python:3.10from
miss-islington:backport-2713631-3.10
Feb 20, 2023
ConversationCommits (1)ChecksFiles changed
Merged

[3.10] gh-101981: Build macOS as recommended by the devguide (GH-102070)#102073
erlend-aasland merged 1 commit into
python:3.10from
miss-islington:backport-2713631-3.10

Conversation

miss-islington commented Feb 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 2713631)

Co-authored-by: Erlend E. Aasland erlend.aasland@protonmail.com
Automerge-Triggered-By: GH:erlend-aasland

pythongh-101981: Build macOS as recommended by the devguide (pythonGH…
1054aa5 
…-102070)

(cherry picked from commit 2713631)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland
This was referenced Feb 20, 2023
Closed
Merged

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

cc. @corona10, @hugovk: any idea regarding the OpenSSL 3.1.0-beta1 failure?

corona10 commented Feb 20, 2023

Copy link
Copy Markdown
Member 
install apps/openssl -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl
install tools/c_rehash -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/c_rehash
/home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory

corona10 commented Feb 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Re-run the job?, I would like to check if this is a temporal issue or not.

corona10 commented Feb 20, 2023

Copy link
Copy Markdown
Member

Ah okay..

install libssl.so.3 -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/lib64/libssl.so.3
/home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory

hugovk commented Feb 20, 2023

Copy link
Copy Markdown
Member

It's a failing Ubuntu job, so unrelated to this PR.

corona10 commented Feb 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

It's a failing Ubuntu job, so unrelated to this PR.

+1, Should be solved by a separate issue.

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

cc. @pablogsal as RM for Python 3.10; see comments about failing CI. Are you fine with me landing this?

pablogsal commented Feb 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for checking with me!

This looks good to me but I am not sure what comment are your referring to about failing CI. It seems that the issue in the CI was transient/unrelated, no?

hugovk commented Feb 20, 2023

Copy link
Copy Markdown
Member

Yes, unrelated, and also failing on a clean 3.10 run:

https://github.com/hugovk/cpython/actions/runs/4224278452/jobs/7335046068

erlend-aasland merged commit 63877f6 into python:3.10 Feb 20, 2023
miss-islington deleted the backport-2713631-3.10 branch February 20, 2023 14:52

corona10 commented Feb 20, 2023

Copy link
Copy Markdown
Member

See how to fix it: #102079

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
corona10 corona10 approved these changes
erlend-aasland erlend-aasland approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL