gh-87092: Make jump target label equal to the offset of the target in the instructions sequence - #102093
Merged
iritkatriel merged 6 commits intoFeb 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…the instructions sequence
iritkatriel
requested review from
brandtbucher and
markshannon
as code owners
February 21, 2023 00:03
iritkatriel
commented
Feb 22, 2023
Comment thread
Python/compile.c
Outdated
Copy link
Copy Markdown
Member
Author
|
This windows test failure is unrelated. Note that this PR is only changing test code. |
Sorry, something went wrong.
Comment thread
Python/compile.c
Outdated
iritkatriel
commented
Feb 27, 2023
Comment thread
Lib/test/support/bytecode_helper.py
Outdated
Copy link
Copy Markdown
Member
Author
|
@markshannon Did you say you've had look at this PR? |
Sorry, something went wrong.
markshannon
approved these changes
Feb 28, 2023
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Since this is only for testing, I'll trust you that is a worthwhile change.
It looks correct.
Sorry, something went wrong.
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Feb 28, 2023
* main: (67 commits) pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308) pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333) pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331) pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309) Migrate to new PSF mailgun account (python#102284) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193) pythonGH-90744: Fix erroneous doc links in the sys module (python#101319) pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093) pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102) IDLE: Simplify DynOptionsMenu __init__code (python#101371) pythongh-101561: Add typing.override decorator (python#101564) pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843) pythongh-101773: Optimize creation of Fractions in private methods (python#101780) pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254) pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297) pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287) pythongh-101100: Fix sphinx warnings in `types` module (python#102274) pythongh-91038: Change default argument value to `False` instead of `0` (python#31621) pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283) [doc] Improve grammar/fix missing word (pythonGH-102060) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the instruction stream exposed by the compiler to Python for testing, the labels are no longer included as explicit entries. Instead, the offset of the target instruction in the stream is used.
This is a step towards the codegen producing an instruction stream instead of basic blocks.