FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101981: Consolidate macOS configure steps in CI by erlend-aasland · Pull Request #102131 · python/cpython · GitHub

/ cpython Public

gh-101981: Consolidate macOS configure steps in CI - #102131

Merged
miss-islington merged 3 commits into
python:mainfrom
erlend-aasland:fixup-macos-build-again
Feb 23, 2023
Merged

gh-101981: Consolidate macOS configure steps in CI#102131
miss-islington merged 3 commits into
python:mainfrom
erlend-aasland:fixup-macos-build-again

Conversation

erlend-aasland commented Feb 21, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Automerge-Triggered-By: GH:erlend-aasland

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks! Let's see if it works :)

Copy link
Copy Markdown
Contributor Author

LGTM, thanks! Let's see if it works :)

Thanks for the heads-up, I had forgotten about this :)

Now, I also adjusted the PKG_CONFIG_PATH variable to adhere to the recommendations of the devguide. We'll see how that fares.

Copy link
Copy Markdown
Contributor Author

I'll have to look at the CI failure tomorrow; over and out from Scandinavia.

corona10 commented Feb 22, 2023
edited
Loading

Copy link
Copy Markdown
Member

It doesn't works and this is not the temproal issue.
it seems like test_toolsreference the GITHUB_ENV, so if we want to make this pass.
IMHO, we should make test_tools to reference the configure scope variable.

Copy link
Copy Markdown
Contributor Author

See fix in #102152

erlend-aasland marked this pull request as ready for review February 23, 2023 14:34

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

miss-islington merged commit e07b304 into python:main Feb 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

Copy link
Copy Markdown

GH-102177 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2023
…2131)

(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland
bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2023
…2131)

(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland

Copy link
Copy Markdown

GH-102178 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 23, 2023
erlend-aasland deleted the fixup-macos-build-again branch February 23, 2023 17:11
miss-islington added a commit that referenced this pull request Feb 23, 2023
(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland
miss-islington added a commit that referenced this pull request Feb 23, 2023
(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL