FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.10] gh-97786: Fix compiler warnings in pytime.c (GH-101826) by mdickinson · Pull Request #102150 · python/cpython · GitHub

/ cpython Public

[3.10] gh-97786: Fix compiler warnings in pytime.c (GH-101826) - #102150

Merged
mdickinson merged 3 commits into
python:3.10from
mdickinson:backport-b1b375e-3.10
Feb 26, 2023
ConversationCommits (3)ChecksFiles changed
Merged

[3.10] gh-97786: Fix compiler warnings in pytime.c (GH-101826)#102150
mdickinson merged 3 commits into
python:3.10from
mdickinson:backport-b1b375e-3.10

Conversation

mdickinson commented Feb 22, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fixes compiler warnings in pytime.c..
(cherry picked from commit b1b375e)

[3.10] pythongh-97786: Fix compiler warnings in pytime.c (pythonGH-10…
3d56ece 
…1826)

Fixes compiler warnings in pytime.c..
(cherry picked from commit b1b375e)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
This was referenced Feb 22, 2023
Closed
Merged
mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2023

bedevere-bot commented Feb 22, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 3d56ece 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2023

gpshead commented Feb 23, 2023

Copy link
Copy Markdown
Member

!buildbot wasm

bedevere-bot commented Feb 23, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit a54b679 🤖

The command will test the builders whose names match following regular expression: wasm

The builders matched are:

  • wasm32-emscripten node (pthreads) PR
  • wasm32-emscripten browser (dynamic linking, no tests) PR
  • wasm32-wasi PR
  • wasm32-emscripten node (dynamic linking) PR

abalkin approved these changes Feb 23, 2023
View reviewed changes

abalkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since this has already been merged in main (gh-97786), there isn't real need for a review.

In any case, LGTM. I just added a suggestion that should not hold this from being merged.

Comment thread Python/pytime.c
mdickinson merged commit 5b610b5 into python:3.10 Feb 26, 2023
mdickinson deleted the backport-b1b375e-3.10 branch February 26, 2023 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

abalkin abalkin approved these changes
pganssle Awaiting requested review from pganssle pganssle is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL