FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95672 skip fcntl when pipesize is smaller than pagesize by hyeongyun0916 · Pull Request #102163 · python/cpython · GitHub

/ cpython Public

gh-95672 skip fcntl when pipesize is smaller than pagesize - #102163

Merged
corona10 merged 13 commits into
python:mainfrom
hyeongyun0916:test-fcntcl-skip-when-smaller-than-pagesize
Mar 1, 2023
ConversationCommits (13)ChecksFiles changed
Merged

gh-95672 skip fcntl when pipesize is smaller than pagesize#102163
corona10 merged 13 commits into
python:mainfrom
hyeongyun0916:test-fcntcl-skip-when-smaller-than-pagesize

Conversation

hyeongyun0916 commented Feb 23, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

There's a check that attempts to skip the tests if the pipe capacity is 512 bytes, but that's less than the smallest page size on x86.

skip fcntl when pipesize is smaller than pagesize

bedevere-bot mentioned this pull request Feb 23, 2023
Closed
bedevere-bot added the tests Tests in the Lib/test dir label Feb 23, 2023
corona10 self-assigned this Feb 23, 2023
corona10 self-requested a review February 23, 2023 03:31
corona10 requested changes Feb 23, 2023
View reviewed changes
Comment thread Lib/test/test_fcntl.py Outdated
pipesize_default = fcntl.fcntl(test_pipe_w, fcntl.F_GETPIPE_SZ)
pipesize = pipesize_default // 2 # A new value to detect change.
if pipesize < 512: # the POSIX minimum
minimum_pipe_size = os.sysconf('SC_PAGESIZE') # There's a check that attempts to skip the tests if the pipe capacity is 512 bytes, but that's less than the smallest page size on x86.

corona10 Feb 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please follow PEP8: https://peps.python.org/pep-0008/#maximum-line-length

Comment thread Lib/test/test_subprocess.py Outdated
os.close(test_pipe_w)
pipesize = pipesize_default // 2
if pipesize < 512: # the POSIX minimum
minimum_pipe_size = os.sysconf('SC_PAGESIZE') # There's a check that attempts to skip the tests if the pipe capacity is 512 bytes, but that's less than the smallest page size on x86.

corona10 Feb 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ditto

bedevere-bot commented Feb 23, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10 reviewed Feb 23, 2023
View reviewed changes
Comment thread Lib/test/test_fcntl.py Outdated
pipesize_default = fcntl.fcntl(test_pipe_w, fcntl.F_GETPIPE_SZ)
pipesize = pipesize_default // 2 # A new value to detect change.
if pipesize < 512: # the POSIX minimum
minimum_pipe_size = os.sysconf('SC_PAGESIZE') # There's a check that attempts to skip the tests if the pipe capacity is 512 bytes, but that's less than the smallest page size on x86.

corona10 Feb 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There's a check that attempts to skip the tests if the pipe capacity is 512 bytes, but that's less than the smallest page size on x86.

You need to describe why the os.sysconf('SC_PAGESIZE') is needed rather than describe the issue itself.

corona10 reviewed Feb 24, 2023
View reviewed changes
Comment thread Lib/test/test_fcntl.py Outdated
hasattr(fcntl, "F_SETPIPE_SZ") and hasattr(fcntl, "F_GETPIPE_SZ"),
"F_SETPIPE_SZ and F_GETPIPE_SZ are not available on all platforms.")
def test_fcntl_f_pipesize(self):
resource = import_module('resource')

corona10 Feb 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why not just using import resource?

hyeongyun0916 Feb 25, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh that's right, I'll fix it.

corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 25, 2023
corona10 reviewed Feb 25, 2023
View reviewed changes
Comment thread Lib/test/test_fcntl.py Outdated
import struct
import sys
import unittest
import resource

corona10 Feb 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@hyeongyun0916 resource module looks like not available on Windows platform.

hyeongyun0916 Mar 1, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll add a function to the test support.

hyeongyun0916 commented Mar 1, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py
interval = minimum_interval
return sys.setswitchinterval(interval)

def get_pagesize():

hyeongyun0916 Mar 1, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll change https://github.com/python/cpython/blob/main/Lib/test/memory_watchdog.py#L13 to get_pagesize in other pr.

corona10 removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 1, 2023
corona10 reviewed Mar 1, 2023
View reviewed changes
Comment thread Doc/library/test.rst
corona10 reviewed Mar 1, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py
corona10 reviewed Mar 1, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py
corona10 reviewed Mar 1, 2023
View reviewed changes
Comment thread Lib/test/test_fcntl.py Outdated
import sys
import unittest
from test import support
from test.support import verbose, cpython_only

corona10 Mar 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
from test.support import verbose, cpython_only
from test.support import verbose, cpython_only, get_pagesize

corona10 reviewed Mar 1, 2023
View reviewed changes
Comment thread Lib/test/test_fcntl.py Outdated
import struct
import sys
import unittest
from test import support

corona10 Mar 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
from test import support

hyeongyun0916 and others added 5 commits March 1, 2023 21:01
Update Lib/test/support/__init__.py
ca6a96e 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Update Lib/test/support/__init__.py
e14a345 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Update Doc/library/test.rst
d5c4006 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
apply reivew
60fe601
Merge branch 'main' into test-fcntcl-skip-when-smaller-than-pagesize
bf11762
corona10 approved these changes Mar 1, 2023
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!
Thanks for the hardwork!

corona10 merged commit 2f62a5d into python:main Mar 1, 2023
hyeongyun0916 mentioned this pull request Mar 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes
gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

corona10

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL