FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Modules/) by iritkatriel · Pull Request #102196 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Modules/) - #102196

Merged
iritkatriel merged 20 commits into
python:mainfrom
iritkatriel:fetch-restore-modules
Feb 24, 2023
ConversationCommits (20)ChecksFiles changed
Merged

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Modules/)#102196
iritkatriel merged 20 commits into
python:mainfrom
iritkatriel:fetch-restore-modules

Conversation

iritkatriel commented Feb 24, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This includes most of the PyErr_Fetch in Modules/. I left out a few which are a little more complicated.

bedevere-bot mentioned this pull request Feb 24, 2023
Closed
iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023

bedevere-bot commented Feb 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 04985db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023

bedevere-bot commented Feb 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 6798b05 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
kumaraditya303 approved these changes Feb 24, 2023
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Short on time so only reviewing asyncio changes.

erlend-aasland commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

LGTM. Short on time so only reviewing asyncio changes.

FTR, I've looked over the rest.

iritkatriel merged commit 2db23d1 into python:main Feb 24, 2023
iritkatriel deleted the fetch-restore-modules branch April 3, 2023 17:45
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient al…
7aed8f3 
…ternatives (in Modules/) (python#102196)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
kumaraditya303 kumaraditya303 approved these changes
berkerpeksag Awaiting requested review from berkerpeksag
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL