gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in tkinter module - #102319
Merged
iritkatriel merged 1 commit intoMar 1, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ternatives in tkinter module
iritkatriel
force-pushed
the
tkinter-exc_info
branch
from
06c073a to
e68fa8b
Compare
February 28, 2023 10:47
markshannon
reviewed
Feb 28, 2023
Comment thread
Modules/_tkinter.c
| static int quitMainLoop = 0; | ||
| static int errorInCmd = 0; | ||
| static PyObject *excInCmd; | ||
| static PyObject *valInCmd; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
These were unused before this PR?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
They were used in a couple of Restore() calls, scroll down.
Sorry, something went wrong.
markshannon
approved these changes
Feb 28, 2023
Copy link
Copy Markdown
Member
|
I have not followed on these new APIs, but I have no problem trusting you @iritkatriel and @markshannon :-) |
Sorry, something went wrong.
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type and traceback are redundant now.