gh-102344: implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx - #102345
Merged
zooba merged 10 commits intoMar 1, 2023
Merged
gh-102344: implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx#102345zooba merged 10 commits into
zooba merged 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
eryksun
reviewed
Mar 1, 2023
Comment thread
PC/winreg.c
Outdated
Co-authored-by: Eryk Sun <eryksun@gmail.com>
zooba
reviewed
Mar 1, 2023
Copy link
Copy Markdown
Contributor
|
Why did you revert the update of winreg_QueryValueEx_impl()? Did it cause tests to fail? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
yes I reverted it, since it caused test timeouts. I was not directly sure what I did wrong, so I reverted it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some review already took place in #102256: