FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-102397: Fix segfault from race condition in signal handling by kumaraditya303 · Pull Request #102399 · python/cpython · GitHub

/ cpython Public

GH-102397: Fix segfault from race condition in signal handling - #102399

Merged
kumaraditya303 merged 7 commits into
python:mainfrom
kumaraditya303:signal
Mar 8, 2023
ConversationCommits (7)ChecksFiles changed
Merged

GH-102397: Fix segfault from race condition in signal handling#102399
kumaraditya303 merged 7 commits into
python:mainfrom
kumaraditya303:signal

Conversation

kumaraditya303 commented Mar 3, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Mar 3, 2023
Closed
kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 3, 2023

bedevere-bot commented Mar 3, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit f52a046 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 3, 2023
gpshead self-requested a review March 3, 2023 19:33

kumaraditya303 commented Mar 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The failing refleak bots are unrelated, I'll add news.

kumaraditya303 marked this pull request as ready for review March 4, 2023 06:49
kumaraditya303 added needs backport to 3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels Mar 4, 2023
gpshead self-assigned this Mar 8, 2023
gpshead reviewed Mar 8, 2023
View reviewed changes
Comment thread Modules/signalmodule.c
kumaraditya303 merged commit 1a84cc0 into python:main Mar 8, 2023

miss-islington commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Sorry @kumaraditya303, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 1a84cc007e207f2dd61f86a7fc3d86632fdce72f 3.11

kumaraditya303 deleted the signal branch March 8, 2023 07:59

bedevere-bot commented Mar 8, 2023

Copy link
Copy Markdown

GH-102527 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2023
pythonGH-102397: Fix segfault from race condition in signal handling (p…
86df1af 
…ythonGH-102399)

(cherry picked from commit 1a84cc0)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
kumaraditya303 added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Mar 8, 2023

miss-islington commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2023
pythonGH-102397: Fix segfault from race condition in signal handling (p…
415e956 
…ythonGH-102399)

(cherry picked from commit 1a84cc0)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-bot commented Mar 8, 2023

Copy link
Copy Markdown

GH-102528 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 8, 2023
kumaraditya303 added a commit that referenced this pull request Mar 8, 2023
[3.10] GH-102397: Fix segfault from race condition in signal handling (…
c4fb418 
…GH-102399) (#102527)

GH-102397: Fix segfault from race condition in signal handling (GH-102399)
(cherry picked from commit 1a84cc0)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request Mar 8, 2023
GH-102397: Fix segfault from race condition in signal handling (GH-10…
7905ae7 
…2399)

(cherry picked from commit 1a84cc0)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

Assignees

kumaraditya303

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL