gh-102406: replace exception chaining by PEP-678 notes in codecs - #102407
Merged
iritkatriel merged 7 commits intoMar 21, 2023
Merged
gh-102406: replace exception chaining by PEP-678 notes in codecs#102407iritkatriel merged 7 commits into
iritkatriel merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'm not sure why wrapping of the codec errors was added in the first place. IMHO the encoding name and codec operation should be clear enough from the stacktrace. However using exception notes for that is definitiely an improvement. I fear that I can't review the patch in detail, as I'm no longer familiar with Python's C API. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit af91411 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
erlend-aasland
approved these changes
Mar 21, 2023
Comment thread
Misc/NEWS.d/next/Core and Builtins/2023-03-03-23-21-16.gh-issue-102406.XLqYO3.rst
Outdated
gpshead
self-requested a review
March 21, 2023 20:06
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
gpshead
approved these changes
Mar 21, 2023
gpshead
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Excellent cleanup!
Sorry, something went wrong.
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102406.
This replaces exception wrapping in codecs by PEP-678 notes.
Simplifies the code and removes the restrictions that prevent wrapping of exceptions that we cannot safely create copies of (because they have args or __init__ overrides, etc).