[3.11] Fix unused classes in a typing test (GH-102437) - #102441
Merged
miss-islington merged 1 commit intoMar 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
As part of investigation issue python#102433, I discovered what I believe to be an error where two classes `CI` and `DI` are not being used. The assertions beneath them act on `C` and `D`, duplicating existing assertions in this test. (cherry picked from commit 7894bbe) Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com> Automerge-Triggered-By: GH:AlexWaygood
miss-islington
requested review from
AlexWaygood,
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
March 5, 2023 15:07
AlexWaygood
approved these changes
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of investigation issue #102433, I discovered what I believe to be an error where two classes CI and DI are not being used. The assertions beneath them act on C and D, duplicating existing assertions in this test.
(cherry picked from commit 7894bbe)
Co-authored-by: JosephSBoyle 48555120+JosephSBoyle@users.noreply.github.com
Automerge-Triggered-By: GH:AlexWaygood